Remove sass variable #1694
Merged
Remove sass variable #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3f77fd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
temporarily deployed
to
review-pr-1694
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Whoops, could you add to this test to catch any more? https://github.com/primer/view_components/blob/main/test/components/component_css_test.rb#L17 |
camertron
force-pushed
the
fix_layout_sass_variable
branch
from
a3ea629
to
3f77fd2
Compare
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jonrohan
approved these changes
Dec 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Got some super weird errors in dotcom when attempting to use PVC
main. Looks like a sass variable snuck through.Integration
No.
Merge checklist
Added/updated testsAdded/updated documentationAdded/updated previews